Py2k Elimination (phase 2): Scrubbing all the py2/3 compatibility clauses #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantuni
reviewed
Mar 27, 2020
kantuni
approved these changes
Mar 27, 2020
Collaborator
|
LGTM! |
tconkling
added a commit
that referenced
this pull request
Mar 30, 2020
* develop: Release 0.57.1 - Fixes SessionInfo alert bug (#1270) Py2k Elimination (phase 2): Scrubbing all the py2/3 compatibility clauses (#1177) Changing selectbox filtering as case insensitive (#1269) Moving st_in_cache_warning from flaky to stable (#1267) DataFrame | Fixing column width behavior (#1258) Release 0.57 (#1266) Fix bug where script was executing twice on first run. (#1263) Add default hash func for regex patterns (#1232) Updated readme.md help people find msft installation instructions. MediaFileManager: fix "Content-Type" header
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 30, 2020
* feature/plugins: Release 0.57.1 - Fixes SessionInfo alert bug (streamlit#1270) Py2k Elimination (phase 2): Scrubbing all the py2/3 compatibility clauses (streamlit#1177) Changing selectbox filtering as case insensitive (streamlit#1269) Moving st_in_cache_warning from flaky to stable (streamlit#1267) DataFrame | Fixing column width behavior (streamlit#1258) Release 0.57 (streamlit#1266) Fix bug where script was executing twice on first run. (streamlit#1263) Add default hash func for regex patterns (streamlit#1232) Updated readme.md help people find msft installation instructions. MediaFileManager: fix "Content-Type" header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1126
Description: To complete this PR, I visually scanned every single line of code in the codebase looking for clauses designed to accommodate python2. Both the production code and the tests were scrubbed.
Major clauses excoriated:
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.