Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 13, 2017

No description provided.

@ghost ghost closed this Jan 13, 2017
@ghost ghost reopened this Jan 13, 2017
@codecov-io
Copy link

codecov-io commented Jan 13, 2017

Current coverage is 47.30% (diff: 50.00%)

Merging #414 into master will increase coverage by <.01%

@@             master       #414   diff @@
==========================================
  Files            56         56          
  Lines          4833       4839     +6   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2286       2289     +3   
- Misses         2547       2550     +3   
  Partials          0          0          

Powered by Codecov. Last update 8d73f62...553e042

@beardypig
Copy link
Member

beardypig commented Jan 13, 2017

Thanks! If you are going to do more of these PEP8 fixes can you roll them up into one PR?

@ghost ghost changed the title Remove extraneous whitespace. PEP8 Jan 13, 2017
@ghost
Copy link
Author

ghost commented Jan 13, 2017

@beardypig are you gonna accept all of them? Because some of them was not merged in other projects. I put all non-aggressive (default) autopep8 fixes in this PR.

@beardypig
Copy link
Member

Most of them I will accept, if you put them in separate commits with the appropriate message it will be easier to filter out the ones that we don't want.
Can you drop the line length limit (E501 I think).

@ghost ghost closed this Jan 13, 2017
@ghost ghost reopened this Jan 13, 2017
@beardypig
Copy link
Member

All of those look reasonable to me, thanks :)

@ghost
Copy link
Author

ghost commented Jan 13, 2017

I'm done. Except E265, don't know about this one.

@beardypig
Copy link
Member

Cool, looks good... E309 isn't part of PEP8, it's part of PEP257 and it doesn't look like autopep8 does it correctly.

@ghost
Copy link
Author

ghost commented Jan 13, 2017

@beardypig Ok, reverted it.

@gravyboat
Copy link
Member

@beardypig these look good to me, any other concerns/questions? If not @stepshal can you rebase after #417 is merged?

@ghost
Copy link
Author

ghost commented Jan 13, 2017

@gravyboat No. Done.

@gravyboat
Copy link
Member

gravyboat commented Jan 16, 2017

@beardypig If you don't have any additional comments when you're around tomorrow let's squash and merge this.

@beardypig
Copy link
Member

Looking good to merge. @stepshal thanks for breaking them out in to separate commits, that must have been a bit of a pain :) Good job!

@gravyboat
Copy link
Member

@beardypig Do you want to keep all these PRs separate in the event we need to roll back? If not I would like to squash since it's a large number of commits and it might crowd the history.

@beardypig
Copy link
Member

Yeah squash it!

@gravyboat gravyboat merged commit 34e6854 into streamlink:master Jan 16, 2017
@gravyboat
Copy link
Member

Done, thanks @stepshal!

fozzysec pushed a commit to fozzysec/streamlink that referenced this pull request Jan 21, 2017
* Remove extraneous whitespace.

* Fix non-membership check.

* Add absent indentation for hanging indentation.

* Align closing bracket to match visual indentation.

* Indent to distinguish line from next logical line.

* Fix over-idented lines for visual indentation.

* Fix under-idented lines for visual indentation.

* Fix bare except:

* Remove missing whitespace.

* Fix missing whitespace around arithmetic operator.

* Fix missing whitespace around operator.

* Fix over-indented hanging indentation.

* Remove whitespace around parameter '=' sign.

* Align closing bracket to match opening bracket.

* Fix spacing after comment hash for inline comments.

* Replace tabs with spaces.

* Fix over-indented hanging indentation.

* Fix comparison with boolean.

* Remove extraneous escape of newline.

* Align closing bracket to match opening bracket.

* Make identation multiple of four.

* Fix extraneous whitespace around keywords.

* Put colon-separated compound statement on separate lines.

* Put semicolon-separated compound statement on separate lines.

* Fix extraneous whitespace around keywords.

* Add missing 2 blank lines.

* Remove extra blank lines.

* Put imports on separate lines.

* Fix do not assign a lambda expression check.

* Add missing blank line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants