-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
PEP8 #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 #414
Conversation
Current coverage is 47.30% (diff: 50.00%)@@ master #414 diff @@
==========================================
Files 56 56
Lines 4833 4839 +6
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2286 2289 +3
- Misses 2547 2550 +3
Partials 0 0
|
|
Thanks! If you are going to do more of these PEP8 fixes can you roll them up into one PR? |
|
@beardypig are you gonna accept all of them? Because some of them was not merged in other projects. I put all non-aggressive (default) autopep8 fixes in this PR. |
|
Most of them I will accept, if you put them in separate commits with the appropriate message it will be easier to filter out the ones that we don't want. |
|
All of those look reasonable to me, thanks :) |
|
I'm done. Except E265, don't know about this one. |
|
Cool, looks good... E309 isn't part of PEP8, it's part of PEP257 and it doesn't look like |
|
@beardypig Ok, reverted it. |
|
@beardypig these look good to me, any other concerns/questions? If not @stepshal can you rebase after #417 is merged? |
|
@gravyboat No. Done. |
|
@beardypig If you don't have any additional comments when you're around tomorrow let's squash and merge this. |
|
Looking good to merge. @stepshal thanks for breaking them out in to separate commits, that must have been a bit of a pain :) Good job! |
|
@beardypig Do you want to keep all these PRs separate in the event we need to roll back? If not I would like to squash since it's a large number of commits and it might crowd the history. |
|
Yeah squash it! |
|
Done, thanks @stepshal! |
* Remove extraneous whitespace. * Fix non-membership check. * Add absent indentation for hanging indentation. * Align closing bracket to match visual indentation. * Indent to distinguish line from next logical line. * Fix over-idented lines for visual indentation. * Fix under-idented lines for visual indentation. * Fix bare except: * Remove missing whitespace. * Fix missing whitespace around arithmetic operator. * Fix missing whitespace around operator. * Fix over-indented hanging indentation. * Remove whitespace around parameter '=' sign. * Align closing bracket to match opening bracket. * Fix spacing after comment hash for inline comments. * Replace tabs with spaces. * Fix over-indented hanging indentation. * Fix comparison with boolean. * Remove extraneous escape of newline. * Align closing bracket to match opening bracket. * Make identation multiple of four. * Fix extraneous whitespace around keywords. * Put colon-separated compound statement on separate lines. * Put semicolon-separated compound statement on separate lines. * Fix extraneous whitespace around keywords. * Add missing 2 blank lines. * Remove extra blank lines. * Put imports on separate lines. * Fix do not assign a lambda expression check. * Add missing blank line.
No description provided.