stream.hds: omit HDS streams that are protected by DRM #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 47.98% (diff: 0.00%)@@ master #417 diff @@
==========================================
Files 57 57
Lines 4885 4889 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2346 2346
- Misses 2539 2543 +4
Partials 0 0
|
Merged
Member
|
Thanks @beardypig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #406 (comment); I have found a better way to deal with the encrypted HDS streams, by simply omitting them when parsing the manifest file.
If the
drmAdditionalHeaderelement has some content then it's protected by DRM, so that stream is skipped.