-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
setup.cfg: added flake8 settings #2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
=======================================
Coverage 52.86% 52.86%
=======================================
Files 239 239
Lines 14971 14971
=======================================
Hits 7915 7915
Misses 7056 7056 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
=======================================
Coverage 52.86% 52.86%
=======================================
Files 239 239
Lines 14971 14971
=======================================
Hits 7915 7915
Misses 7056 7056 |
| venv/, | ||
| versioneer.py, | ||
| win32/, | ||
| max-line-length = 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
I'm good with this. Let's see if anyone else weighs in, mostly @bastimeyer. |
|
Is the intention of this PR that editors/IDEs can pick up a common linting config? Because that's just the linting config, the actual linter is not being used in the CI. IIRC, a linter was never added after the fork, because the argument back then was that it was not important at that time. Now, if we add a linting config, then we should also enable it in the CI, so that every PR can be checked. However, if we add it now, then a lot of work needs to be done first (similar to #414). I'm not sure about the Python-world, but do these linting tools here support automatic code fixing? (I usually don't trust auto-fixing stuff though) The longer we wait, the more work needs to be done in the future. We could allow linting failures for now though, but I'm not sure how useful it would be, especially when checking new PRs. |
yes
that could be done in the future, but this PR is just for the editors/IDEs |
|
Are we good to merge this? Is something still holding it up? |
|
I'm OK with it. |
|
Merging then. Thanks @back-to! |
setup.cfg: added flake8 settings
No description provided.