Improve terminal progress display for wide characters #2032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acters
In python 2, Fix malformed displayed prefix because prefix is cut by bytes , not by unicode chars.
In python 2 & 3, Calculate prefix width in terminal replace of prefix length because east asian characters length 1 and width 2.
…nts and add tests.
beardypig
reviewed
Oct 2, 2018
|
|
||
| Attempts to decode the string as UTF-8 first if it's a bytestring. | ||
| """ | ||
| widths = [ |
Member
There was a problem hiding this comment.
unicodedata.east_asian_width might be a better way to get this data?
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Using east_asian_width has some issues. (https://stackoverflow.com/a/31666966)
The width table in this Pull Request is based on https://github.com/urwid/urwid/blob/master/urwid/old_str_util.py#L38
Another better way is using library wcwidth(https://github.com/jquast/wcwidth)
Thanks for reviewing.
Member
|
Are we good to go here @beardypig or is there further feedback? |
beardypig
approved these changes
Oct 11, 2018
Member
beardypig
left a comment
There was a problem hiding this comment.
Looks good to me :) Thanks @jackyzy823
Member
|
Thanks @jackyzy823, and thanks for the review @beardypig. |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 1, 2020
streamlink 1.3.1 (2020-01-27)
A small patch release that addresses the removal of MPV's legacy option syntax, also with fixes of several plugins, the addition of the --twitch-disable-reruns parameter and dropped support for Python 3.4.
streamlink 1.3.0 (2019-11-22)
A new release with plugin updates and fixes, including Twitch.tv (see #2680), which had to be delayed due to back and forth API changes.
The Twitch.tv workarounds mentioned in #2680 don't have to be applied anymore, but authenticating via --twitch-oauth-token has been disabled, regardless of the origin of the OAuth token (via --twitch-oauth-authenticate or the Twitch website). In order to not introduce breaking changes, both parameters have been kept in this release and the user name will still be logged when using an OAuth token, but receiving item drops or accessing restricted streams is not possible anymore.
Plugins for the following sites have also been added:
albavision
news.now.com
twitcasting.tv
viu.tv
vlive.tv
willax.tv
streamlink 1.2.0 (2019-08-18)
Here are the changes for this month's release
Multiple plugin fixes
Fixed single hyphen params at the beginning of --player-args (#2333)
--http-proxy will set the default value of --https-proxy to same as --http-proxy. (#2536)
DASH Streams will handle headers correctly (#2545)
the timestamp for FFMPEGMuxer streams will start with zero (#2559)
streamlink 1.1.1 (2019-04-02)
This is just a small patch release which fixes a build/deploy issue with the new special wheels for Windows on PyPI. (#2392)
streamlink 1.0.0 (2019-01-30)
The celebratory release of Streamlink 1.0.0!
A lot of hard work has gone into getting Streamlink to where it is. Not only is Streamlink used across multiple applications and platforms, but companies as well.
Streamlink started from the inaugural fork of Livestreamer on September 17th, 2016.
Since then, We've hit multiple milestones:
Over 886 PRs
Hit 3,000 commits in Streamlink
Obtaining our first sponsors as well as backers of the project
The creation of our own logo (streamlink/streamlink#1123)
Thanks to everyone who has contributed to Streamlink (and our backers)! Without you, we wouldn't be where we are today.
Without further ado, here are the changes in release 1.0.0:
We have a new icon / logo for Streamlink! (streamlink/streamlink#2165)
Updated dependencies (streamlink/streamlink#2230)
A ton of plugin updates. Have a look at this search query for all the recent updates.
You can now provide a custom key URI to override HLS streams (streamlink/streamlink#2139). For example: --hls-segment-key-uri <URI>
User agents for API communication have been updated (streamlink/streamlink#2194)
Special synonyms have been added to sort "best" and "worst" streams (streamlink/streamlink#2127). For example: streamlink --stream-sorting-excludes '>=480p' URL best,best-unfiltered
Process output will no longer show if tty is unavailable (streamlink/streamlink#2090)
We've removed BountySource in favour of our OpenCollective page. If you have any features you'd like to request, please open up an issue with the request and possibly consider backing us!
Improved terminal progress display for wide characters (streamlink/streamlink#2032)
Fixed a bug with dynamic playlists on playback (streamlink/streamlink#2096)
Fixed makeinstaller.sh (streamlink/streamlink#2098)
Old Livestreamer deprecations and API references were removed (streamlink/streamlink#1987)
Dependencies have been updated for Python (streamlink/streamlink#1975)
Newer and more common User-Agents are now used (streamlink/streamlink#1974)
DASH stream bitrates now round-up to the nearest 10, 100, 1000, etc. (streamlink/streamlink#1995)
Updated documentation on issue templates (streamlink/streamlink#1996)
URL have been added for better processing of HTML tags (streamlink/streamlink#1675)
Fixed sort and prog issue (streamlink/streamlink#1964)
Reformatted issue templates (streamlink/streamlink#1966)
Fixed crashing bug with player-continuous-http option (streamlink/streamlink#2234)
Make sure all dev dependencies (streamlink/streamlink#2235)
-r parameter has been replaced for --rtmp-rtmpdump (streamlink/streamlink#2152)
Breaking changes:
A large number of unmaintained or NSFW plugins have been removed. You can find the PR that implemented that change here: streamlink/streamlink#2003 . See our CONTRIBUTING.md documentation for plugin policy.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 6, 2020
streamlink 1.3.1 (2020-01-27)
A small patch release that addresses the removal of MPV's legacy option syntax, also with fixes of several plugins, the addition of the --twitch-disable-reruns parameter and dropped support for Python 3.4.
streamlink 1.3.0 (2019-11-22)
A new release with plugin updates and fixes, including Twitch.tv (see #2680), which had to be delayed due to back and forth API changes.
The Twitch.tv workarounds mentioned in #2680 don't have to be applied anymore, but authenticating via --twitch-oauth-token has been disabled, regardless of the origin of the OAuth token (via --twitch-oauth-authenticate or the Twitch website). In order to not introduce breaking changes, both parameters have been kept in this release and the user name will still be logged when using an OAuth token, but receiving item drops or accessing restricted streams is not possible anymore.
Plugins for the following sites have also been added:
albavision
news.now.com
twitcasting.tv
viu.tv
vlive.tv
willax.tv
streamlink 1.2.0 (2019-08-18)
Here are the changes for this month's release
Multiple plugin fixes
Fixed single hyphen params at the beginning of --player-args (#2333)
--http-proxy will set the default value of --https-proxy to same as --http-proxy. (#2536)
DASH Streams will handle headers correctly (#2545)
the timestamp for FFMPEGMuxer streams will start with zero (#2559)
streamlink 1.1.1 (2019-04-02)
This is just a small patch release which fixes a build/deploy issue with the new special wheels for Windows on PyPI. (#2392)
streamlink 1.0.0 (2019-01-30)
The celebratory release of Streamlink 1.0.0!
A lot of hard work has gone into getting Streamlink to where it is. Not only is Streamlink used across multiple applications and platforms, but companies as well.
Streamlink started from the inaugural fork of Livestreamer on September 17th, 2016.
Since then, We've hit multiple milestones:
Over 886 PRs
Hit 3,000 commits in Streamlink
Obtaining our first sponsors as well as backers of the project
The creation of our own logo (streamlink/streamlink#1123)
Thanks to everyone who has contributed to Streamlink (and our backers)! Without you, we wouldn't be where we are today.
Without further ado, here are the changes in release 1.0.0:
We have a new icon / logo for Streamlink! (streamlink/streamlink#2165)
Updated dependencies (streamlink/streamlink#2230)
A ton of plugin updates. Have a look at this search query for all the recent updates.
You can now provide a custom key URI to override HLS streams (streamlink/streamlink#2139). For example: --hls-segment-key-uri <URI>
User agents for API communication have been updated (streamlink/streamlink#2194)
Special synonyms have been added to sort "best" and "worst" streams (streamlink/streamlink#2127). For example: streamlink --stream-sorting-excludes '>=480p' URL best,best-unfiltered
Process output will no longer show if tty is unavailable (streamlink/streamlink#2090)
We've removed BountySource in favour of our OpenCollective page. If you have any features you'd like to request, please open up an issue with the request and possibly consider backing us!
Improved terminal progress display for wide characters (streamlink/streamlink#2032)
Fixed a bug with dynamic playlists on playback (streamlink/streamlink#2096)
Fixed makeinstaller.sh (streamlink/streamlink#2098)
Old Livestreamer deprecations and API references were removed (streamlink/streamlink#1987)
Dependencies have been updated for Python (streamlink/streamlink#1975)
Newer and more common User-Agents are now used (streamlink/streamlink#1974)
DASH stream bitrates now round-up to the nearest 10, 100, 1000, etc. (streamlink/streamlink#1995)
Updated documentation on issue templates (streamlink/streamlink#1996)
URL have been added for better processing of HTML tags (streamlink/streamlink#1675)
Fixed sort and prog issue (streamlink/streamlink#1964)
Reformatted issue templates (streamlink/streamlink#1966)
Fixed crashing bug with player-continuous-http option (streamlink/streamlink#2234)
Make sure all dev dependencies (streamlink/streamlink#2235)
-r parameter has been replaced for --rtmp-rtmpdump (streamlink/streamlink#2152)
Breaking changes:
A large number of unmaintained or NSFW plugins have been removed. You can find the PR that implemented that change here: streamlink/streamlink#2003 . See our CONTRIBUTING.md documentation for plugin policy.
Billy2011
pushed a commit
to Billy2011/streamlink-27
that referenced
this pull request
May 14, 2020
* [cli.util] fix progressbar issue when prefix contains east asian characters
In python 2, Fix malformed displayed prefix because prefix is cut by bytes , not by unicode chars.
In python 2 & 3, Calculate prefix width in terminal replace of prefix length because east asian characters length 1 and width 2.
* [cli.util] use more accurate character width data from unicode documents and add tests.
* [cli.util] remove unused import in util.progress
mkbloke
pushed a commit
to mkbloke/streamlink
that referenced
this pull request
Aug 18, 2020
* [cli.util] fix progressbar issue when prefix contains east asian characters
In python 2, Fix malformed displayed prefix because prefix is cut by bytes , not by unicode chars.
In python 2 & 3, Calculate prefix width in terminal replace of prefix length because east asian characters length 1 and width 2.
* [cli.util] use more accurate character width data from unicode documents and add tests.
* [cli.util] remove unused import in util.progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overflow sample:
Malformed sample
Some details
1 Wide character takes 2 cells in terminal