chore(types) remove bespoke rollup types#3009
Merged
rwaskiewicz merged 1 commit intorwaskiewicz-rebase-again-sourcemapsfrom Aug 19, 2021
Merged
Conversation
this PR replaces our custom typings for rollup hooks with those provided by rollup
rwaskiewicz
added a commit
that referenced
this pull request
Sep 20, 2021
this PR replaces our custom typings for rollup hooks with those provided by rollup
rwaskiewicz
added a commit
that referenced
this pull request
Sep 30, 2021
duplicate the typings for rollup (again). Stencil cannot resolve the rollup typings in the private compiler api typings at run time for consuming projects. As a result, we duplicate the sourcemap typings from rollup partial revert of #3009
14 tasks
rwaskiewicz
added a commit
that referenced
this pull request
Oct 5, 2021
duplicate the typings for rollup (again). Stencil cannot resolve the rollup typings in the private compiler api typings at run time for consuming projects. As a result, we duplicate the sourcemap typings from rollup partial revert of #3009
johnjenkins
pushed a commit
to johnjenkins/stencil
that referenced
this pull request
Oct 7, 2021
this PR replaces our custom typings for rollup hooks with those provided by rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR replaces our custom typings for rollup hooks with those
provided by rollup
since this is only a change to the typings, I did not do any functional testing, rather ensured the compiler still ran