fix(typings): fix external typings for rollup#3088
Merged
rwaskiewicz merged 2 commits intorwaskiewicz-rebase-again-sourcemapsfrom Oct 5, 2021
Merged
Conversation
duplicate the typings for rollup (again). Stencil cannot resolve the rollup typings in the private compiler api typings at run time for consuming projects. As a result, we duplicate the sourcemap typings from rollup partial revert of #3009
ltm
approved these changes
Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Stencil won't run on the sourcemaps branch after busting caches
GitHub Issue Number: N/A
What is the new behavior?
duplicate the typings for rollup (again).
Why? Well, turns out stencil cannot resolve the rollup typings in the private compiler api
typings at run time for consuming projects. As a result, we duplicate
the sourcemap typings from rollup
partial revert of #3009
Does this introduce a breaking change?
Testing
I built the project in full and ran the dev-server in a newly spun up project
Other information