Summary

Refactored the ApplyApChange trait to modify values in-place rather than returning new values. This changes the signature from fn apply_known_ap_change(self, ap_change: usize) -> Option<Self> to fn apply_known_ap_change(&mut self, ap_change: usize) -> bool, which simplifies error handling and avoids unnecessary cloning. The implementation also improves the handling of AP change overflow by using num_traits::ToPrimitive for safer conversions.

Type of change

Please check one:

• Bug fix (fixes incorrect behavior)
• New feature
• Performance improvement
• Documentation change with concrete technical impact
• Style, wording, formatting, or typo-only change

Why is this change needed?

The previous implementation of ApplyApChange required cloning and recreating objects when applying AP changes. By modifying values in-place, we can avoid unnecessary allocations and improve performance, especially in code paths that apply AP changes frequently.

What was the behavior or documentation before?

Previously, apply_known_ap_change consumed self and returned a new instance wrapped in an Option, requiring callers to handle the None case separately and often leading to unnecessary cloning of data structures.

What is the behavior or documentation after?

Now apply_known_ap_change takes &mut self and returns a boolean indicating success, which is more efficient and follows a more conventional error-handling pattern. The implementation also uses num_traits::ToPrimitive for safer numeric conversions.

Additional context

This change affects multiple implementations of the ApplyApChange trait across the codebase, including ResOperand, CellRef, DerefOrImmediate, BinOpOperand, CellExpression, and ReferenceExpression. Tests have been updated to use a helper function that maintains the previous API for testing purposes.