Conversation
|
This change is |
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 11, 2026
TomerStarkware
approved these changes
Jan 12, 2026
Collaborator
TomerStarkware
left a comment
There was a problem hiding this comment.
@TomerStarkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware).
7a719e0 to
63d2f2c
Compare
This was referenced Jan 13, 2026
Closed
Using the info that generated it directly. SIERRA_UPDATE_MINOR_CHANGE_TAG=No behaviour change.
63d2f2c to
344a942
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the relocation logic in the Sierra-to-CASM compiler to improve code clarity and efficiency. The changes include:
applymethod in theRelocationenum to use helper closures for calculating offsetsType of change
Please check one:
Why is this change needed?
The relocation logic in the Sierra-to-CASM compiler was unnecessarily complex and inefficient. This refactoring simplifies the code by eliminating redundant data structures and calculations, making the code more maintainable and slightly more efficient.
What was the behavior or documentation before?
The compiler was creating a separate collection of statement offsets and using more verbose code patterns for handling relocations. It was also creating new relocation entries instead of modifying existing ones in-place.
What is the behavior or documentation after?
The compiler now directly uses the sierra_statement_info for relocations, eliminating the redundant statement_offsets collection. The relocation logic is more concise with helper closures, and relocation entries are modified in-place rather than creating new ones.