Skip to content

Conversation

@srutzky
Copy link
Owner

@srutzky srutzky commented Jan 5, 2018

sync

bartdesmet and others added 30 commits December 22, 2017 12:07
* added ms.workload values

* added dotnetcore ms.workload value to standard folder
…ntent (#4002)

* Add warning about usage of PreSendRequestHeaders

see https://github.com/aspnet/Docs/pull/5054/files

* PreSendRequestContent too

* feedback
Make the last section header ('private protected') look like a header in this document: https://docs.microsoft.com/en-us/dotnet/csharp/whats-new/csharp-7-2
AspNetCompatibilityRequirements without [ and in the same line of ServiceContract. Added new line with correct code..
* Fix typo

Reported via LiveFyre

* Update working-with-linq.md
* fix OS version

* Feedback
HypenatedConcat -> HyphenatedConcat in several places
* Tidy code samples

* Add missing syntax highlighting
provide an example of a test output with a custom name to a custom folder
Remove extra bullet in data-driven-crud-microservice, this extra bullet was inserted in the middle of the sentence.
added Ubuntu 17.10 apt source and updated 2.x version in apt-get statement
As it was, the statement was incorrect. Structured exception handling could be used instead of an "On Error..." statement.
* Updated WCF Test Client path

Path to find WCF test client updated for latest release of Visual Studio, as well as a reminder depending on the version of Visual Studio installed.

* Expanded explanation on the versioning of Visual Studio affecting path
jasonmarcher and others added 19 commits January 3, 2018 11:46
It looks like some formatting markup got into the code examples.  This makes the example code not valid.  Removing them.
memorycache, namedcache : attribute in add element should be physicalMemoryLimitPercentage instead of physicalMemoryPercentage
The link to ".NET Framework 4.5" was pointing to #vcore which directed to the "Core" section in "What's new in the .NET Framework 4.7.1". Created new #v45 in order to be consistent with nomenclature.
* sync method's argument list with sample's code

* small code formatting

* to follow coding conventions by Microsoft
Edit 19 line: remove '\' symbol from 'Expression<Func\<int,bool>>' to 'Expression<Func<int,bool>>'
* initial checkin

* switching machines

* added find / grep output

* finixh 1st pass

* update TOC and proofread

* respond to feedback

* pare the LINQ section.
* Update walkthroughs-technical-get-started-overview.md

Some links weren't working because they had two "https://". This is my first edit on Gitbub and I'm not sure if it is ok to edit the file here, so, sorry if that's not ok.

Thanks,
Hasan.

* Update walkthroughs-technical-get-started-overview.md

Fixed link to Walkthrough 2
* Minor naming fix

* Addressed review feedback
* Updated link to Native Image Service

Updated link to Native Image Service to last version available

* Updated remaining links to Native Image Service

Updated remaining links to Native Image Service to latest available version of the document

* Minor naming fix

* Addressed review feedback
@srutzky srutzky merged commit 92b1c80 into srutzky:master Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.