Skip to content

Conversation

@lomholdt
Copy link
Contributor

@lomholdt lomholdt commented Jan 4, 2018

Title

On the title describe
what you've fixed (or created) with this Pull Request (PR).

Summary

Insert a short (one or two sentence) summary here.

Fixes #Issue_Number

Note: The "Fixes #nnn" syntax in the PR description causes
GitHub to automatically close the issue when this PR is merged.
Remove that line if you don't have issues associated with this
PR. Click on the Guidelines for Contributing link above for details.

Details

Explain your changes, and why you made them. If that
information is already available in the issue referenced
above, just referencing the issue is preferred to copying
the text.

This may not be necessary depending on the scope of the PR
changes. For example, "fix typo in introduction.md" is
sufficient to describe that PR.

Suggested Reviewers

If you know who should review this, use '@' to request a review.

@JRAlexander JRAlexander added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Jan 4, 2018
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and fixing it @lomholdt We appreciate it.

I've reviewed your changes, and I'll :shipit: now. You should see the changes on our live site in the next day or two, on our regular publishing cycle.

Thanks again.

@BillWagner BillWagner merged commit 64aafc4 into dotnet:master Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants