Skip to content

Conversation

@Goraf
Copy link
Contributor

@Goraf Goraf commented Jan 4, 2018

Details

Argument's list in the initial definition of MakeWithdrawal method was different than later one when implementations of method's body was provided. It could result in unnecessary compilation error if user adds only implementation of the body and try tests provided in tutorial.

@dnfclas
Copy link

dnfclas commented Jan 4, 2018

CLA assistant check
All CLA requirements met.

@JRAlexander JRAlexander added the ✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository label Jan 4, 2018
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates @Goraf We really appreciate it.

I've reviewed the changes and I'll :shipit: now. The changes should show up on our next regular publish cycle in the next day or so.

Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ 1st-time docs contributor! Indicates PRs from new contributors to the docs repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants