Fix Quality Report reproducibility #562
Merged
vmarkovtsev merged 3 commits intosrc-d:masterfrom Feb 9, 2019
Merged
Conversation
vmarkovtsev
requested changes
Jan 30, 2019
This was referenced Jan 30, 2019
Merged
08d6358 to
bdee1cc
Compare
Contributor
Author
|
So, I manage to make it work but I restart bblfshd each time by scripts. Pros: it is automatic. Cons: Can not run inside a regular container (docker is required). I think it is fine for such tools. |
ce9531d to
f77b802
Compare
zurk
added a commit
to zurk/lookout-sdk-ml
that referenced
this pull request
Feb 1, 2019
I need this fix src-d/lookout#409 to make this PR work: src-d/style-analyzer#562
zurk
added a commit
to zurk/lookout-sdk-ml
that referenced
this pull request
Feb 1, 2019
I need this fix src-d/lookout#409 to make this PR work: src-d/style-analyzer#562 Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
This was referenced Feb 1, 2019
zurk
added a commit
to zurk/lookout-sdk-ml
that referenced
this pull request
Feb 1, 2019
I need this fix src-d/lookout#409 to make this PR work: src-d/style-analyzer#562 Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
5fd50a6 to
131a01b
Compare
zurk
added a commit
to zurk/lookout-sdk-ml
that referenced
this pull request
Feb 1, 2019
I need this fix src-d/lookout#409 to make this PR work: src-d/style-analyzer#562 Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
Contributor
Author
|
🎉 |
vmarkovtsev
requested changes
Feb 6, 2019
Contributor
Author
|
addressed. |
vmarkovtsev
requested changes
Feb 7, 2019
| def get_vnodes_number(repository: str, from_commit: str, to_commit: str, port: int, | ||
| bblfsh: Optional[str]) -> int: | ||
| """ | ||
| Get expected vnodes number for a repository. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Get expected vnodes number for a repository. | |
| Calculate the number of expected vnodes for a repository. |
| vnodes_parsed_number = sum(len(vn) for vn, _, _ in parsed_files) | ||
| self._log.debug("Parsed %d vnodes", vnodes_parsed_number) | ||
| if self.vnodes_number_callback is not None: | ||
| self.vnodes_number_callback(vnodes_parsed_number) |
Collaborator
There was a problem hiding this comment.
I am going to split extract_features into several functions and you will not have to add this callback. Stay tuned.
Collaborator
|
@zurk Once we merge #589 you will be able to original_files_to_xy = FeatureExtractor._files_to_xy
def hacked_files_to_xy(self, parsed_files):
vnodes_parsed_number = sum(len(vn) for vn, _, _ in parsed_files)
# do whatever with it
return original_files_to_xy(self, parsed_files)
FeatureExtractor._files_to_xy = hacked_files_to_xy |
Contributor
Author
|
Good! |
Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
Contributor
Author
|
@vmarkovtsev done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on PR #517.
Closes #557.