Skip to content

Add input file for quality report#517

Merged
m09 merged 1 commit intosrc-d:masterfrom
zurk:feaute/qreport_input_file
Jan 30, 2019
Merged

Add input file for quality report#517
m09 merged 1 commit intosrc-d:masterfrom
zurk:feaute/qreport_input_file

Conversation

@zurk
Copy link
Copy Markdown
Contributor

@zurk zurk commented Jan 9, 2019 •
edited
Loading

Closes: #433 (comment)

Also you can run

cat data/quality_report_repos.csv | grep "url\|telescope" | \
    python3 -m lookout.style.format.benchmarks.top_repos_quality -o telescope_report -i -

to get report for telescope only.

@vmarkovtsev
Copy link
Copy Markdown
Collaborator

vmarkovtsev commented Jan 9, 2019

@zurk Please do not do any refactoring until we discuss it tomorrow.

@zurk
Copy link
Copy Markdown
Contributor Author

zurk commented Jan 9, 2019

ok, I stop here for now.

@zurk zurk force-pushed the feaute/qreport_input_file branch from 48b950f to f789cad Compare January 14, 2019 12:20
@m09
Copy link
Copy Markdown
Contributor

m09 commented Jan 18, 2019

What is the status of this PR? How did our discussions impact it?

@zurk
Copy link
Copy Markdown
Contributor Author

zurk commented Jan 18, 2019

Well, it is ready to be reviewed and merged if merging did not require a lot of additional work from your (@m09) or @EgorBu side. Because I assume that you are busy with big refactoring issues.

@zurk zurk force-pushed the feaute/qreport_input_file branch 2 times, most recently from 44ee9e2 to 3854cc2 Compare January 25, 2019 10:00
@zurk
Copy link
Copy Markdown
Contributor Author

zurk commented Jan 25, 2019

Rebased and ready for review.

@zurk
Add input file for quality report
75ab844 
Signed-off-by: Konstantin Slavnov <konstantin@sourced.tech>
@zurk zurk force-pushed the feaute/qreport_input_file branch from 3854cc2 to 75ab844 Compare January 29, 2019 13:12
@zurk zurk requested a review from vmarkovtsev January 29, 2019 14:34
@zurk
Copy link
Copy Markdown
Contributor Author

zurk commented Jan 29, 2019

Rebased one more time. Let's review and merge it?

@zurk zurk mentioned this pull request Jan 29, 2019
Merged
m09
m09 approved these changes Jan 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@m09 m09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m09 m09 merged commit fa9282b into src-d:master Jan 30, 2019
@zurk zurk mentioned this pull request Jan 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmarkovtsev vmarkovtsev Awaiting requested review from vmarkovtsev

1 more reviewer

@m09 m09 m09 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zurk @vmarkovtsev @m09