Fix Jackson Deserializer for AuthenticationExtensionsClientOutputs#18897
Merged
rwinch merged 7 commits intospring-projects:7.0.xfrom Mar 16, 2026
Merged
Fix Jackson Deserializer for AuthenticationExtensionsClientOutputs#18897rwinch merged 7 commits intospring-projects:7.0.xfrom
rwinch merged 7 commits intospring-projects:7.0.xfrom
Conversation
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
The deserializer is updated to properly ignore unknown extensions. Closes spring-projectsgh-18643 Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
The deserializer is updated to properly ignore unknown extensions. This fix addresses the WebAuthn authentication failure appeared when using FIDO2 security keys on Safari. Closes spring-projectsgh-18643 Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes gh-18643, targeting Spring Security 7.0.x.
The changes here was previously submitted in PR #18644. I was thinking about a workflow of merging into 7.0.x first and backporting to 6.5.x, but it seems that Spring Security always fixes on the oldest supported version and merges forward. To make it easier to merge, I am now spliting PR #18644 into two new PRs, i.e. #18896 and #18897 (i.e. this one).
In this PR, I merge
gh-18864-6.5.x(i.e. PR #18896) to fix the Jackson 2 deserializer, manually resolve the conflict caused by classes renaming (introduced during v6-to-v7 migration), and then fix the Jackson 3 deserializer.Therefore, this PR contains the forward-port of #18896 for Jackson 2 as well as the fix for Jackson 3 deserializer. It could be and is intended to be directly merged into 7.0.x without the “#18896 -> 6.5.x -> 7.0.x” steps.