Fix deserializer for AuthenticationExtensionsClientOutputs#18644
Closed
ziqin wants to merge 3 commits intospring-projects:mainfrom
Closed
Fix deserializer for AuthenticationExtensionsClientOutputs#18644ziqin wants to merge 3 commits intospring-projects:mainfrom
ziqin wants to merge 3 commits intospring-projects:mainfrom
Conversation
jzheaux
requested changes
Mar 5, 2026
webauthn/src/test/java/org/springframework/security/web/webauthn/jackson/Jackson2Tests.java
Show resolved
Hide resolved
webauthn/src/test/java/org/springframework/security/web/webauthn/jackson/JacksonTests.java
Show resolved
Hide resolved
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
The deserializer is updated to properly ignore unknown extensions. This fix addresses the WebAuthn authentication failure appeared when using FIDO2 security keys on Safari. Closes spring-projectsgh-18643 Signed-off-by: Ziqin Wang <ziqin@wangziqin.net>
Contributor
Author
|
Hi, @jzheaux I have rebased this PR on 7.0.x. The two tests are now placed on earlier commits and the GitHub issue is now mentioned in the fixing commit message. Thanks for your review. |
Contributor
Author
|
I believe that this fix should also be backported to 6.5.x because the deserilization bug also exists there, although it may not cause an immediate WebAuthn authentication failure. |
This was referenced Mar 15, 2026
Contributor
Author
|
To work with Spring Security's merge-forward branching strategy, I have splitted this PR into two new ones: #18896 and #18897, targeting 6.5.x and 7.0.x respectively. I have made #18896 a parent of #18897, hoping this could ease the merge. If appropriate, consider closing this PR in favor of the two new ones. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deserializer is updated to properly ignore unknown extensions.
This PR fixes gh-18643.