Conversation
- Use onLastOperator instead of onEachOperator - Do not instrument scalar publishers - Revisit ReactorSleuthMethodInvocationProcessor to reduce ops overhead
- Use only one operator for the MethodInvocationProcessor - Warning Behavior Change: @Newspan will defer Span creation/context
- Reduce WebFilter instrumentation to 1 operator - Reduce WebClient instrumentation to 2 operators (1 resp, 1 body)
|
Moar Reactor optimization + fixing thread local populated on WebClient body emissions (see Spring Cloud Sample ITIssue) |
codefromthecrypt
left a comment
There was a problem hiding this comment.
so much formatting change.. mind making a line comment per major thing what is important here? I would like to learn.
| private static final class SpanSubscriber | ||
| implements CoreSubscriber<Object>, Subscription, Scannable { | ||
|
|
||
| final CoreSubscriber<? super Object> actual; |
There was a problem hiding this comment.
nit this doublespacing is stress testing my thumbs ability to swipe up!
|
After this PR it looks like tracing headers are added to the context only when |
…tion) Before spring-cloud#1126, the headers were eagerly set in `TraceExchangeFilterFunction#filter`. After it, the side effect was moved to lazy `MonoWebClientTrace#subscribe`. However, we have everything to instrument the request in `filter`, and it can be done eagerly.
* Fix regression introduced in #1126 (brave headers propagation) Before #1126, the headers were eagerly set in `TraceExchangeFilterFunction#filter`. After it, the side effect was moved to lazy `MonoWebClientTrace#subscribe`. However, we have everything to instrument the request in `filter`, and it can be done eagerly fixes gh-1199
No description provided.