Fix regression introduced in #1126 (brave headers propagation)#1206
Merged
marcingrzejszczak merged 2 commits intospring-cloud:masterfrom Feb 5, 2019
Merged
Fix regression introduced in #1126 (brave headers propagation)#1206marcingrzejszczak merged 2 commits intospring-cloud:masterfrom
marcingrzejszczak merged 2 commits intospring-cloud:masterfrom
Conversation
…tion) Before spring-cloud#1126, the headers were eagerly set in `TraceExchangeFilterFunction#filter`. After it, the side effect was moved to lazy `MonoWebClientTrace#subscribe`. However, we have everything to instrument the request in `filter`, and it can be done eagerly.
Contributor
Author
That's exactly what we're discussing with @marcingrzejszczak right now in Slack :D Will check shortly, I like writing tests 👍 |
Contributor
Author
|
FYI the manual testing was done with the repro project from #1199 |
Contributor
Author
|
@spencergibb ok, writing a test took less than 15 minutes 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #1206 +/- ##
============================================
- Coverage 69.95% 69.94% -0.01%
Complexity 753 753
============================================
Files 141 141
Lines 3521 3520 -1
Branches 383 383
============================================
- Hits 2463 2462 -1
Misses 845 845
Partials 213 213
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before #1126, the headers were eagerly set in
TraceExchangeFilterFunction#filter. After it, the side effect wasmoved to lazy
MonoWebClientTrace#subscribe.However, we have everything to instrument the request in
filter,and it can be done eagerly.
This should fix #1199