Conversation
hazendaz
approved these changes
Sep 30, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
For reference, both this and #2391 got published as part of Spotbugs 4.8.0. |
This was referenced Nov 29, 2023
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Jun 30, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `SpotBugs` to 4.9.3. ### Why are the changes needed? To bring the latest improvements like Java 21 support, - https://github.com/spotbugs/spotbugs/releases/tag/4.9.3 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.2 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.1 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.0 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.5 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.4 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.3 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.2 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.1 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.0 - spotbugs/spotbugs#2578 ### How was this patch tested? Manual check the CI logs **BEFORE** - https://github.com/apache/orc/actions/runs/15979589321/job/45070631476 (Java 21) ``` [java] Exception analyzing org.apache.orc.impl.AircompressorCodec$1 using detector edu.umd.cs.findbugs.detect.FindOpenStream [java] org.apache.bcel.classfile.ClassFormatException: Invalid constant pool reference using index: 0. Constant pool size is: 28 [java] At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:305) [java] At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:257) [java] At edu.umd.cs.findbugs.detect.FindOpenStream.visitClassContext(FindOpenStream.java:304) [java] At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76) [java] At edu.umd.cs.findbugs.FindBugs2.lambda$analyzeApplication$1(FindBugs2.java:1108) [java] At java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [java] At edu.umd.cs.findbugs.CurrentThreadExecutorService.execute(CurrentThreadExecutorService.java:86) [java] At java.base/java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:247) [java] At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1118) [java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:309) [java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395) [java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231) ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2306 from dongjoon-hyun/ORC-1944. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
to apache/orc
that referenced
this pull request
Jun 30, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `SpotBugs` to 4.9.3. ### Why are the changes needed? To bring the latest improvements like Java 21 support, - https://github.com/spotbugs/spotbugs/releases/tag/4.9.3 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.2 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.1 - https://github.com/spotbugs/spotbugs/releases/tag/4.9.0 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.5 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.4 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.3 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.2 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.1 - https://github.com/spotbugs/spotbugs/releases/tag/4.8.0 - spotbugs/spotbugs#2578 ### How was this patch tested? Manual check the CI logs **BEFORE** - https://github.com/apache/orc/actions/runs/15979589321/job/45070631476 (Java 21) ``` [java] Exception analyzing org.apache.orc.impl.AircompressorCodec$1 using detector edu.umd.cs.findbugs.detect.FindOpenStream [java] org.apache.bcel.classfile.ClassFormatException: Invalid constant pool reference using index: 0. Constant pool size is: 28 [java] At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:305) [java] At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:257) [java] At edu.umd.cs.findbugs.detect.FindOpenStream.visitClassContext(FindOpenStream.java:304) [java] At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76) [java] At edu.umd.cs.findbugs.FindBugs2.lambda$analyzeApplication$1(FindBugs2.java:1108) [java] At java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317) [java] At edu.umd.cs.findbugs.CurrentThreadExecutorService.execute(CurrentThreadExecutorService.java:86) [java] At java.base/java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:247) [java] At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1118) [java] At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:309) [java] At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395) [java] At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231) ``` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2306 from dongjoon-hyun/ORC-1944. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 4126a7f) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
9.5->9.69.5->9.69.5->9.69.5->9.69.5->9.6Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.