Skip to content

ORC-1944: Upgrade spotbugs to 4.9.3#2306

Closed
dongjoon-hyun wants to merge 2 commits intoapache:mainfrom
dongjoon-hyun:ORC-1944
Closed

ORC-1944: Upgrade spotbugs to 4.9.3#2306
dongjoon-hyun wants to merge 2 commits intoapache:mainfrom
dongjoon-hyun:ORC-1944

Conversation

@dongjoon-hyun
Copy link
Copy Markdown
Member

@dongjoon-hyun dongjoon-hyun commented Jun 30, 2025

What changes were proposed in this pull request?

This PR aims to upgrade SpotBugs to 4.9.3.

Why are the changes needed?

To bring the latest improvements like Java 21 support,

How was this patch tested?

Manual check the CI logs

BEFORE

[java]   Exception analyzing org.apache.orc.impl.AircompressorCodec$1 using detector edu.umd.cs.findbugs.detect.FindOpenStream
     [java]     org.apache.bcel.classfile.ClassFormatException: Invalid constant pool reference using index: 0. Constant pool size is: 28
     [java]       At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:305)
     [java]       At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:257)
     [java]       At edu.umd.cs.findbugs.detect.FindOpenStream.visitClassContext(FindOpenStream.java:304)
     [java]       At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
     [java]       At edu.umd.cs.findbugs.FindBugs2.lambda$analyzeApplication$1(FindBugs2.java:1108)
     [java]       At java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
     [java]       At edu.umd.cs.findbugs.CurrentThreadExecutorService.execute(CurrentThreadExecutorService.java:86)
     [java]       At java.base/java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:247)
     [java]       At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1118)
     [java]       At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:309)
     [java]       At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395)
     [java]       At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231)

Was this patch authored or co-authored using generative AI tooling?

No.

dongjoon-hyun added a commit that referenced this pull request Jun 30, 2025
### What changes were proposed in this pull request?

This PR aims to upgrade `SpotBugs` to 4.9.3.

### Why are the changes needed?

To bring the latest improvements like Java 21 support,

- https://github.com/spotbugs/spotbugs/releases/tag/4.9.3
- https://github.com/spotbugs/spotbugs/releases/tag/4.9.2
- https://github.com/spotbugs/spotbugs/releases/tag/4.9.1
- https://github.com/spotbugs/spotbugs/releases/tag/4.9.0
- https://github.com/spotbugs/spotbugs/releases/tag/4.8.5
- https://github.com/spotbugs/spotbugs/releases/tag/4.8.4
- https://github.com/spotbugs/spotbugs/releases/tag/4.8.3
- https://github.com/spotbugs/spotbugs/releases/tag/4.8.2
- https://github.com/spotbugs/spotbugs/releases/tag/4.8.1
- https://github.com/spotbugs/spotbugs/releases/tag/4.8.0
  - spotbugs/spotbugs#2578

### How was this patch tested?

Manual check the CI logs

**BEFORE**
- https://github.com/apache/orc/actions/runs/15979589321/job/45070631476 (Java 21)
```
[java]   Exception analyzing org.apache.orc.impl.AircompressorCodec$1 using detector edu.umd.cs.findbugs.detect.FindOpenStream
     [java]     org.apache.bcel.classfile.ClassFormatException: Invalid constant pool reference using index: 0. Constant pool size is: 28
     [java]       At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:305)
     [java]       At org.apache.bcel.classfile.ConstantPool.getConstant(ConstantPool.java:257)
     [java]       At edu.umd.cs.findbugs.detect.FindOpenStream.visitClassContext(FindOpenStream.java:304)
     [java]       At edu.umd.cs.findbugs.DetectorToDetector2Adapter.visitClass(DetectorToDetector2Adapter.java:76)
     [java]       At edu.umd.cs.findbugs.FindBugs2.lambda$analyzeApplication$1(FindBugs2.java:1108)
     [java]       At java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
     [java]       At edu.umd.cs.findbugs.CurrentThreadExecutorService.execute(CurrentThreadExecutorService.java:86)
     [java]       At java.base/java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:247)
     [java]       At edu.umd.cs.findbugs.FindBugs2.analyzeApplication(FindBugs2.java:1118)
     [java]       At edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:309)
     [java]       At edu.umd.cs.findbugs.FindBugs.runMain(FindBugs.java:395)
     [java]       At edu.umd.cs.findbugs.FindBugs2.main(FindBugs2.java:1231)
```

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2306 from dongjoon-hyun/ORC-1944.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 4126a7f)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Copy Markdown
Member Author

Merged to main/2.1.

@dongjoon-hyun dongjoon-hyun deleted the ORC-1944 branch June 30, 2025 22:56
@dongjoon-hyun dongjoon-hyun added this to the 2.1.3 milestone Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant