Partial fix org.apache.bcel:bcel dependency update#2446
Merged
hazendaz merged 2 commits intospotbugs:renovate/org.apache.bcel-bcel-6.xfrom Jun 10, 2023
JuditKnoll:renovate/org.apache.bcel-bcel-6.x
Merged
Partial fix org.apache.bcel:bcel dependency update#2446hazendaz merged 2 commits intospotbugs:renovate/org.apache.bcel-bcel-6.xfrom JuditKnoll:renovate/org.apache.bcel-bcel-6.x
hazendaz merged 2 commits intospotbugs:renovate/org.apache.bcel-bcel-6.xfrom
JuditKnoll:renovate/org.apache.bcel-bcel-6.x
Conversation
hazendaz
approved these changes
Jun 10, 2023
Member
|
Thanks @JuditKnoll Appreciate all the work you are putting in here. |
hazendaz
added a commit
that referenced
this pull request
Oct 5, 2023
* fix(deps): update dependency org.apache.bcel:bcel to v6.7.0 * Partial fix org.apache.bcel:bcel dependency update (#2446) * Refactor deprecated tests to the new type * Follow the changes in ConstantPool --------- Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Judit Knoll <123470644+JuditKnoll@users.noreply.github.com> Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com> Co-authored-by: Jeremy Landis <jeremylandis@hotmail.com>
hazendaz
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Refactor deprecated tests to the new type * Follow the changes in ConstantPool --------- Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com>
1 task
hazendaz
pushed a commit
that referenced
this pull request
Oct 7, 2023
* Refactor deprecated tests to the new type * Follow the changes in ConstantPool --------- Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com>
JuditKnoll
added a commit
to JuditKnoll/spotbugs
that referenced
this pull request
Dec 8, 2023
* Refactor deprecated tests to the new type * Follow the changes in ConstantPool --------- Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com>
hazendaz
pushed a commit
that referenced
this pull request
Dec 9, 2023
* Partial fix org.apache.bcel:bcel dependency update (#2446) * Refactor deprecated tests to the new type * Follow the changes in ConstantPool --------- Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com> * migrate the tests to junit jupiter
hazendaz
pushed a commit
that referenced
this pull request
Dec 9, 2023
* fix(deps): update dependency org.apache.bcel:bcel to v6.8.0 * Fixes for the bcel update (#2757) * Partial fix org.apache.bcel:bcel dependency update (#2446) * Refactor deprecated tests to the new type * Follow the changes in ConstantPool --------- Co-authored-by: Judit Knoll <judit.knoll@sigmatechnology.com> * migrate the tests to junit jupiter --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Judit Knoll <123470644+JuditKnoll@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a partial fix to the org.apache.bcel:bcel dependency update (#2278), since to solve it completely we will also need a new, currently unreleased version of bcel.
There are several issues with updating to the newest bcel version currently as @nbauma109 already mentioned (#2278 (comment)):
This PR in itself only solves the first problem, since the second one is in bcel itself, and there is already a working solution for it.
Using a snapshot bcel version with the mentioned PR (apache/commons-bcel#221) and the changes in this PR, spotbugs builds successfully on my machine.
So for a successful bcel dependency version update, we will need a new version of bcel containing the mentioned PR, and the changes in this PR.
*Quote from the JVM specification: "All eight byte constants take up two spots in the constant pool. If this is the n'th byte in the constant pool, then the next item will be numbered n+2"
Make sure these boxes are checked before submitting your PR -- thank you!
CHANGELOG.mdif you have changed SpotBugs code