Code coverage and bug fixes for bcelifier#171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
============================================
+ Coverage 58.14% 60.49% +2.35%
- Complexity 3356 3560 +204
============================================
Files 363 363
Lines 15570 15619 +49
Branches 1921 1939 +18
============================================
+ Hits 9053 9449 +396
+ Misses 5633 5296 -337
+ Partials 884 874 -10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hello @nbauma109 Thank you for your PR. There is a lot here but it feels like a mish-mash of different more or less related items. For example, the PR adds the constructor Based on the title of the PR, I was expecting only tests, it's ok to have other work in here, the different pieces should be clearly documented in the PR description. |
|
The constructors
I generated a separate jacoco exec file for the execution of this code, which is merged into the main jacoco.exec, and coverage report is online: src/main/java/org/apache/bcel/generic/PUSH.java The codecov plugin is well made. The checks will fail if new code is not covered by tests. |
| @Override | ||
| public void visitRET(final RET i) { | ||
| printWriter.println("il.append(new RET(" + i.getIndex() + ")));"); | ||
| printWriter.println("il.append(new RET(" + i.getIndex() + "));"); |
Place new method in AB order.
|
@nbauma109 |
While doing coverage, I found a few bugs that needed to be fixed. I collected auxiliary jacoco execution reports for the exec(...) calls and merged them into the main one.