Conversation
tgamblin
requested changes
Oct 31, 2019
Member
tgamblin
left a comment
There was a problem hiding this comment.
one last request: add a test so as to avoid reversion.
tgamblin
approved these changes
Oct 31, 2019
tgamblin
pushed a commit
that referenced
this pull request
Nov 5, 2019
* environments: make shell modifications partially unconditional * flake * missing module name * add regression test * flake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I inadvertently reverted my changes from #12719 in #13249. This reinstates the functionality from #12719.