Environment views: add all paths on activation#12719
Merged
Conversation
4a4046e to
d48fbd8
Compare
tldahlgren
pushed a commit
to tldahlgren/spack
that referenced
this pull request
Oct 11, 2019
jrmadsen
pushed a commit
to jrmadsen/spack
that referenced
this pull request
Oct 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, environments only load existing paths on activation. This means that new packages in the environment do not load properly. For example
results in nothing in
LD_LIBRARY_PATH. Under this PR, it now results in$spack/var/spack/environments/myenv/.spack-env/view/lib:$spack/var/spack/environments/myenv/.spack-env/view/lib64.