Refactor zipfetcher and consistently use rev, not baseref#598
Merged
Conversation
8c1c7ba to
d534942
Compare
eseliger
commented
Sep 2, 2021
| } | ||
|
|
||
| return r.DefaultBranch.Name | ||
| return ensurePrefix(r.DefaultBranch.Name) |
d534942 to
0d1821a
Compare
mrnugget
approved these changes
Sep 3, 2021
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
Didn't look too closely, but idea looks good to me! I like repozip as a package.
| } | ||
| } | ||
|
|
||
| func SlugForPathInRepo(repoName, commit, path string) string { |
Contributor
There was a problem hiding this comment.
Random thought: instead of a util package, could we have a repository package? batches/repository.SlugForPath is a good name.
fe3d712 to
0104d58
Compare
LawnGnome
added a commit
that referenced
this pull request
Oct 6, 2021
Removing this in #598 broke the `src batch repos` command, which used the `url` field when rendering the link to the repo in Sourcegraph.
LawnGnome
added a commit
that referenced
this pull request
Oct 6, 2021
Removing this in #598 broke the `src batch repos` command, which used the `url` field when rendering the link to the repo in Sourcegraph.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Before, sometimes we used Rev, sometimes BaseRef, which could in the worst case lead to inconsistencies. Search results might not match the fetched zip archive, or detected workspaces might differ from what's on disk in the end.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Removing this in #598 broke the `src batch repos` command, which used the `url` field when rendering the link to the repo in Sourcegraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, sometimes we used Rev, sometimes BaseRef, which could in the worst case lead to inconsistencies. Search results might not match the fetched zip archive, or detected workspaces might differ from what's on disk in the end.