internal/batches: include the url field in repositories#625
Merged
Conversation
Removing this in #598 broke the `src batch repos` command, which used the `url` field when rendering the link to the repo in Sourcegraph.
mrnugget
approved these changes
Oct 6, 2021
Member
|
@mrnugget should we include this in the exec json files as well then? I removed it before (for one, because I thought it was unused) because I feared that at some point we use this field on the struct because "it's there", but we didn't pass it down in the SSBC path. |
Contributor
|
Which files? Do you mean the JSON log line output? |
Member
|
The json input file for the |
Contributor
|
It would probably make sense, just to be consistent. |
Contributor
|
Hmm, the I wonder whether it wouldn't be confusing if we tried to reconstruct that method just for the sake of passing it down to |
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
Removing this in #598 broke the `src batch repos` command, which used the `url` field when rendering the link to the repo in Sourcegraph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing this in #598 broke the
src batch reposcommand, which used theurlfield when rendering the link to the repo in Sourcegraph.