Conversation
|
|
||
| type configSource int | ||
|
|
||
| const ( |
There was a problem hiding this comment.
This stuff ended up being unnecessary, will revert.
| AccessToken string `json:"accessToken"` | ||
| AdditionalHeaders map[string]string `json:"additionalHeaders"` | ||
|
|
||
| EndpointSource configSource |
There was a problem hiding this comment.
This stuff ended up being unnecessary, will revert.
| } | ||
| var cfg config | ||
| if err == nil { | ||
| cfg.ConfigFilePath = cfgPath |
There was a problem hiding this comment.
This stuff ended up being unnecessary, will revert.
|
@slimsag mentioned (on Slack):
My reply:
|
|
We could have this populate the config file instead, except I'd suggest that we should simultaneously migrate that file from being |
|
@LawnGnome We've deprecated the config file and are supporting only env var config. See #156 (comment) and #205. |
Fair enough. Thanks for the context! |
547bc04 to
807feac
Compare
You can run `src login https://sourcegraph.example.com` to verify that your `src` is authenticated to access that Sourcegraph instance. If not, it'll show you friendly steps to help you get it set up. This will simplify all of our docs and in-product text that relies on users using the CLI. The steps to get them to the right state will be just: 1. Install the Sourcegraph CLI (`src`) at https://github.com/sourcegraph/src-cli [or link to releases] 1. Run `src login SOURCEGRAPH_URL` [and we can even fill in `SOURCEGRAPH_URL` in in-product text] Also adds a deprecation warning if you have an old-style `src-config.json` file, and updates the README.md to highlight the `src login` command.
You can run
src login https://sourcegraph.example.comto verify that yoursrcis authenticated to access that Sourcegraph instance. If not, it'll show you friendly steps to help you get it set up.This will simplify all of our docs and in-product text that relies on users using the CLI. The steps to get them to the right state will be just:
src) at https://github.com/sourcegraph/src-cli [or link to releases]src login SOURCEGRAPH_URL[and we can even fill inSOURCEGRAPH_URLin in-product text]Here is a screenshot of what it looks like in various states:
README section: