Deprecate config file in favour of env variables#205
Merged
Conversation
We'll still read from the config file but it has been undocumented so that we can remove it at a later point.
Contributor
Author
|
I removed the docs, would it have been better to add a DEPRECATED warning instead? |
mrnugget
approved these changes
May 27, 2020
mrnugget
left a comment
Contributor
There was a problem hiding this comment.
I think it's fine to deprecate it, as long as the PR description/title here contains enough information, since that will show up in the changelog.
scjohns
pushed a commit
that referenced
this pull request
Apr 24, 2023
We still read from the config file but it has been undocumented so that we can remove it at a later point. Users should instead use the SRC_ACCESS_TOKEN and SRC_ENDPOINT environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still read from the config file but it has been undocumented so
that we can remove it at a later point.
Users should instead use the
SRC_ACCESS_TOKENandSRC_ENDPOINTenvironment variables.Part of: #156