This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(svelte): fix test by removing duplicate aria-label#63942
Merged
Conversation
camdencheek
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test that I enable in this PR has been skipped for a while, and has broken again with https://github.com/sourcegraph/sourcegraph/pull/63463, where we added another aria-label. This additional label lead to playwright rejecting the test, because it found two elements for one query.
This PR removes that label, since we already have a similar one at the button one level up. See screenshot below.
Test plan
CI
Changelog