This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: set timeout for web-sveltekit/unit_tests to moderate#63879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit tests for web-sveltekit have become flaky, and have therefore been set to run only manually: https://github.com/sourcegraph/sourcegraph/pull/63874
By running them via
sg ci bazelI noticed in the waterfall view, that the tests are taking slightly above one minute (https://buildkite.com/sourcegraph/sourcegraph/builds/282732/waterfall), and that previous tests failed because it exceeded a timeout of 1 minute: https://buildkite.com/sourcegraph/sourcegraph/builds/282684It looks to me like the CI agents are a bit less powerful, and therefore take longer than our local test runs (which usually don't exceed 10 seconds).
I have not investigated parallelizing the vitest workers, because for web-sveltekit we currently only have a vite config, but not a vitest config. More context on that here: https://github.com/sourcegraph/sourcegraph/pull/60927
Test plan
CI
Changelog