This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: GitTreeTranslator rewrite#63938
Merged
Merged
Conversation
9127720 to
5ec22a0
Compare
7 tasks
5ec22a0 to
d434856
Compare
added 2 commits
July 23, 2024 07:35
use unified diff format and 0 context lines to allow translation by just using hunk headers only request hunks per file once, and sync follow-up requests for the same file don't bother LRU caching the full hunk contents, just store 4 int32's per hunk replace linear search through sorted hunks with binary search
e84cb5f to
f993ba0
Compare
varungandhi-src
approved these changes
Jul 23, 2024
Contributor
Thanks for flagging this. 👍🏽 |
added 6 commits
July 23, 2024 14:53
varungandhi-src
approved these changes
Jul 24, 2024
kritzcreek
pushed a commit
that referenced
this pull request
Jul 24, 2024
Following through after #63938 ## Test plan Existing tests continue to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/GRAPH-742/simplify-gittreetranslator-implementation
Current PR keeps the old PR and just proxies to the new implementation. Once this PR is reviewed and merged I'll remove the old API and update all callsites.
Idea is to make review easier.
I'd recommend just reviewing the new implementation, as the diff view on this is pretty useless.
Test plan
New/existing tests