This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Removes the old GitTreeTranslator API#64027
Merged
Merged
Conversation
varungandhi-src
approved these changes
Jul 24, 2024
Contributor
There was a problem hiding this comment.
This needs a matching PR to sourcegraph/docs removing it or indicating that it no longer has any effect.
Contributor
Author
There was a problem hiding this comment.
It's funny, because the order of this variable and PRECISE_CODE_INTEL_MAXIMUM_INDEXES_PER_MONIKER_SEARCH was swapped in the constructor call, so anyone using that variable was actually not changing the hunk cache size... 😞
Contributor
There was a problem hiding this comment.
At this point, perhaps you can add _ names for the other parameters, and call the api.CommitID something like mappedTo or targetCommit? The other parameters are fairly self-explanatory.
026ed19 to
e0c02b0
Compare
MaedahBatool
referenced
this pull request
in sourcegraph/docs
Aug 16, 2024
Removes an environment variable that is no longer used as of https://github.com/sourcegraph/sourcegraph/pull/64027
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following through after #63938
Test plan
Existing tests continue to pass