This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore/enterpriseportal: properly close DB handle#63426
Merged
bobheadxi merged 1 commit intoJun 21, 2024
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
bobheadxi
commented
Jun 21, 2024
Member
Author
There was a problem hiding this comment.
Moved these into concurrent shutdown because we have quite a few now, don't want to get stuck
unknwon
approved these changes
Jun 21, 2024
Comment on lines
55
to
57
Contributor
There was a problem hiding this comment.
Now I have to copy it to my notebook because I think later we will eventually need this 😂
Member
Author
There was a problem hiding this comment.
It'll always be here in git history 😁
Contributor
There was a problem hiding this comment.
That's true but still not so convenient haha
d0011cc to
74f93b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a clean shutdown for our primary DB handle, and removes some unused code.
Test plan
sg run enterprise-portaland stop it