chore/enterpriseportal: split database package#63425
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
| // order as a t.Cleanup hook. It uses soft-deletion when available and skips | ||
| // deletion when the test suite failed. | ||
| // | ||
| // Future: Move to a shared package when more than Enterprise Portal uses it. |
There was a problem hiding this comment.
It's in a "shared package" now, so we can remove this?
There was a problem hiding this comment.
I think the comment still stands, since the comment says "when more than Enterprise Portal", and currently it's still only available for EP
There was a problem hiding this comment.
i.e. did you mean you want to share this with other MSP services? if so, that's still not the case
There was a problem hiding this comment.
I did not anticipate database package split within EP, but this PR actually does formally making this a utility helper, which archive the same goal.
| // tables for the suite. The test database is dropped after testing is completed | ||
| // unless failed. | ||
| // | ||
| // Future: Move to a shared package when more than Enterprise Portal uses it. |
There was a problem hiding this comment.
It's in a "shared package" now, so we can remove this?
As we set up to introduce more tables to Enterprise Portal, I think it'll be more sustainable for things to get their own subpackages. No real code changes, just moving things around.
Test plan
CI