Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/enterpriseportal: add Salesforce metadata at subscription level#63317

Merged
bobheadxi merged 1 commit into
mainfrom
06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level
Jun 18, 2024
Merged

feat/enterpriseportal: add Salesforce metadata at subscription level#63317
bobheadxi merged 1 commit into
mainfrom
06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Jun 18, 2024

Copy link
Copy Markdown
Member

Today Salesforce "subscription ID" and "opportunity ID" are attached at the license level. They should really be on the Enterprise subscription level instead, which are parent entities of licenses. As we move forward with CORE-149, I think this is a good chance to introduce this change in our schema, and migrate the currently per-license information to the subscription level when we move things into Enterprise Portal.

Test plan

CI

@cla-bot cla-bot Bot added the cla-signed label Jun 18, 2024

bobheadxi commented Jun 18, 2024

Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

@bobheadxi bobheadxi marked this pull request as ready for review June 18, 2024 18:30
@bobheadxi bobheadxi changed the title feat/enterpriseportal: add Salesfroce metadata at subscription level feat/enterpriseportal: add Salesforce metadata at subscription level Jun 18, 2024
@bobheadxi bobheadxi requested review from a team and dadlerj June 18, 2024 18:32
@bobheadxi bobheadxi force-pushed the 06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level branch from 9ab7756 to d68a0c3 Compare June 18, 2024 18:33
@bobheadxi bobheadxi force-pushed the robert/core-149-enterprise-portal-proto-rpc-for-createproductsubscription branch from c2fc7fd to 662080c Compare June 18, 2024 18:34
@bobheadxi bobheadxi force-pushed the 06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level branch from d68a0c3 to 2e3e17f Compare June 18, 2024 18:34
@bobheadxi bobheadxi force-pushed the robert/core-149-enterprise-portal-proto-rpc-for-createproductsubscription branch from 662080c to 907c251 Compare June 18, 2024 19:26
@bobheadxi bobheadxi force-pushed the 06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level branch from 2e3e17f to d104ca0 Compare June 18, 2024 19:26
@bobheadxi bobheadxi changed the base branch from robert/core-149-enterprise-portal-proto-rpc-for-createproductsubscription to graphite-base/63317 June 18, 2024 19:35
@bobheadxi bobheadxi force-pushed the 06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level branch from d104ca0 to 3f6da38 Compare June 18, 2024 19:35
@graphite-app graphite-app Bot changed the base branch from graphite-base/63317 to main June 18, 2024 19:36
@bobheadxi bobheadxi force-pushed the 06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level branch from 3f6da38 to 856fad1 Compare June 18, 2024 20:31
@bobheadxi bobheadxi merged commit a333771 into main Jun 18, 2024

Copy link
Copy Markdown
Member Author

Merge activity

@bobheadxi bobheadxi deleted the 06-18-feat_enterpriseportal_add_salesfroce_metadata_at_subscription_level branch June 18, 2024 20:39
bobheadxi added a commit that referenced this pull request Jun 19, 2024
…nition (#63323)

Defines an RPC for creating licenses for a subscription in Enterprise
Portal (which will replace the existing
`generateProductLicenseForSubscription` GraphQL mutation). Because of
#63317 we will no longer accept Salesforce details as part of the input
for creating licenses. Most everything else stays the same.

https://google.aip.dev/133 says we must name the parent subscription ID
as the `parent` parameter. But, we already have a `subscription_id` in
`EnterpriseSubscriptionLicense`, which feels more descriptive, so I've
opted not to use `parent`... but I'm open to suggestions otherwise 🤷

Closes CORE-150, implementation tracked in CORE-157

## Test plan

CI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants