This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: add Salesforce metadata at subscription level#63317
Merged
bobheadxi merged 1 commit intoJun 18, 2024
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
9ab7756 to
d68a0c3
Compare
c2fc7fd to
662080c
Compare
d68a0c3 to
2e3e17f
Compare
unknwon
approved these changes
Jun 18, 2024
662080c to
907c251
Compare
2e3e17f to
d104ca0
Compare
d104ca0 to
3f6da38
Compare
3f6da38 to
856fad1
Compare
Member
Author
Merge activity
|
bobheadxi
added a commit
that referenced
this pull request
Jun 19, 2024
…nition (#63323) Defines an RPC for creating licenses for a subscription in Enterprise Portal (which will replace the existing `generateProductLicenseForSubscription` GraphQL mutation). Because of #63317 we will no longer accept Salesforce details as part of the input for creating licenses. Most everything else stays the same. https://google.aip.dev/133 says we must name the parent subscription ID as the `parent` parameter. But, we already have a `subscription_id` in `EnterpriseSubscriptionLicense`, which feels more descriptive, so I've opted not to use `parent`... but I'm open to suggestions otherwise 🤷 Closes CORE-150, implementation tracked in CORE-157 ## Test plan CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Today Salesforce "subscription ID" and "opportunity ID" are attached at the license level. They should really be on the Enterprise subscription level instead, which are parent entities of licenses. As we move forward with CORE-149, I think this is a good chance to introduce this change in our schema, and migrate the currently per-license information to the subscription level when we move things into Enterprise Portal.
Test plan
CI