This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: CreateEnterpriseSubscriptionLicense RPC defininition#63323
Merged
Merged
Conversation
unknwon
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines an RPC for creating licenses for a subscription in Enterprise Portal (which will replace the existing
generateProductLicenseForSubscriptionGraphQL mutation). Because of #63317 we will no longer accept Salesforce details as part of the input for creating licenses. Most everything else stays the same.https://google.aip.dev/133 says we must name the parent subscription ID as the
parentparameter. But, we already have asubscription_idinEnterpriseSubscriptionLicense, which feels more descriptive, so I've opted not to useparent... but I'm open to suggestions otherwise 🤷Closes CORE-150, implementation tracked in CORE-157
Test plan
CI