Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feature/internal/database: add test to ensure that not found errors fulfiill errcode.NotFound#63299

Merged
ggilmore merged 1 commit into
mainfrom
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound
Jun 17, 2024
Merged

feature/internal/database: add test to ensure that not found errors fulfiill errcode.NotFound#63299
ggilmore merged 1 commit into
mainfrom
graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound

Conversation

@ggilmore

@ggilmore ggilmore commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is a small change that ensures that the user/repository not found error types fulfill the errcode.NotFound interface. This is a building block for https://app.graphite.dev//github/pr/sourcegraph/sourcegraph/63302

Test plan

Unit tests

Changelog

  • Added unit tests to ensure that the database userNotFound and RepositoryNotFound error types fulfuill the errcode.NotFound interface.

@cla-bot cla-bot Bot added the cla-signed label Jun 17, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jun 17, 2024
This was referenced Jun 17, 2024
Merged
Merged
@ggilmore Graphite App

ggilmore commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore mentioned this pull request Jun 17, 2024
Merged
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch from d4a0c3b to 8b8b223 Compare June 17, 2024 19:49
@ggilmore ggilmore force-pushed the graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound branch from 4d5e82c to c3c0cf5 Compare June 17, 2024 19:49
@ggilmore ggilmore requested a review from a team June 17, 2024 19:54
@ggilmore ggilmore marked this pull request as ready for review June 17, 2024 19:58
eseliger
eseliger approved these changes Jun 17, 2024
View reviewed changes

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@graphite-app

graphite-app Bot commented Jun 17, 2024

Copy link
Copy Markdown

TV gif. Steve Irwin the Crocodile Hunter looking down at a body of water, turns around and gives a double thumbs-up, mouthing 'that's good.' (Added via Giphy)

@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch from 8b8b223 to e06238d Compare June 17, 2024 20:19
@ggilmore ggilmore force-pushed the graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound branch from c3c0cf5 to fd80f0c Compare June 17, 2024 20:19
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories branch from e06238d to cee1f50 Compare June 17, 2024 20:27
@ggilmore ggilmore force-pushed the graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound branch from fd80f0c to 68da82c Compare June 17, 2024 20:28
@ggilmore ggilmore changed the base branch from 06-14-fix_graphql_database_fix_repo_permission_sync_count_to_ignore_soft_deleted_repositories to graphite-base/63299 June 17, 2024 20:35
@graphite-app graphite-app Bot changed the base branch from graphite-base/63299 to main June 17, 2024 20:35
@ggilmore ggilmore force-pushed the graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound branch from 68da82c to b7026c4 Compare June 17, 2024 20:35
@ggilmore ggilmore merged commit fe56852 into main Jun 17, 2024
@ggilmore ggilmore deleted the graphite-ggilmore06-17-feature_internal_database_add_test_to_ensure_that_not_found_errors_fulfiill_errcode.notfound branch June 17, 2024 20:43
@ggilmore Graphite App

ggilmore commented Jun 17, 2024

Copy link
Copy Markdown
Contributor Author

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger