Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix/graphql/database: make count of failed user permissions syncs ignore soft deleted users#63297

Merged
ggilmore merged 1 commit into
mainfrom
06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users
Jun 17, 2024
Merged

fix/graphql/database: make count of failed user permissions syncs ignore soft deleted users#63297
ggilmore merged 1 commit into
mainfrom
06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users

Conversation

@ggilmore

@ggilmore ggilmore commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR changes the query that powers the "failed user sync count" on the permissions center to now properly ignore soft-deleted users. The admin can't take any action to remedy this, so there is no point in displaying it.

Screenshot 2024-06-17 at 12.52.08 PM.png

Test plan

Unit tests

Changelog

  • The failed user permission sync count on the permission dashboard now properly ignores syncs from deleted users (which is the expected behavior).

@cla-bot cla-bot Bot added the cla-signed label Jun 17, 2024
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jun 17, 2024
@ggilmore Graphite App

ggilmore commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

This was referenced Jun 17, 2024
Merged
Merged
Merged
@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users branch from 1ea3cc5 to fe5c54d Compare June 17, 2024 19:49
@ggilmore ggilmore requested a review from a team June 17, 2024 19:54
@ggilmore ggilmore marked this pull request as ready for review June 17, 2024 19:54
eseliger
eseliger approved these changes Jun 17, 2024
View reviewed changes
Comment thread internal/database/permission_sync_jobs_test.go Outdated
@graphite-app

graphite-app Bot commented Jun 17, 2024

Copy link
Copy Markdown

TV gif. Timmy from Shaun the Sheep blinks and extends 2 thumbs up as a lopsided grin emerges on the side of his face. (Added via Giphy)

@ggilmore ggilmore force-pushed the 06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users branch from fe5c54d to 0a4ff76 Compare June 17, 2024 20:19
@ggilmore ggilmore merged commit 1f388d9 into main Jun 17, 2024
@ggilmore ggilmore deleted the 06-14-fix_graphql_database_make_count_of_failed_user_permissions_syncs_ignore_soft_deleted_users branch June 17, 2024 20:27
@ggilmore Graphite App

ggilmore commented Jun 17, 2024

Copy link
Copy Markdown
Contributor Author

Merge activity

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@eseliger eseliger eseliger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggilmore @eseliger