This repository was archived by the owner on Sep 30, 2024. It is now read-only.
insights: Fix overview page#62986
Merged
Merged
Conversation
Forgot a case here when migrating the API to gRPC that could leave an empty ranges slice, which is now forbidden. Thanks to Michael for reporting it! Closes https://github.com/sourcegraph/sourcegraph/issues/62984 Test plan: Verified manually that the page is broken before this change and works again after.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bahrmichael
approved these changes
May 30, 2024
bahrmichael
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the quick fix!
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forgot a case here when migrating the API to gRPC that could leave an empty ranges slice, which is now forbidden.
Thanks to Michael for reporting it!
Closes https://github.com/sourcegraph/sourcegraph/issues/62984
Test plan:
Verified manually that the page is broken before this change and works again after.