This repository was archived by the owner on Sep 30, 2024. It is now read-only.
appliance: initial smoke testing harness#62731
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @craigfurman and the rest of your teammates on |
8d5e7a4 to
2643a32
Compare
2aaec75 to
d5d7bf3
Compare
craigfurman
commented
May 20, 2024
Contributor
Author
There was a problem hiding this comment.
We can imagine calling this from the appliance frontend (the appliance application, as opposed to the kubernetes reconciler/operator) in response to an admin checking a "dev mode" box on the setup web form.
Contributor
There was a problem hiding this comment.
Nice, I like this better than what we had before in the reconciler 💯
craigfurman
commented
May 20, 2024
Comment on lines
48
to
58
Contributor
Author
There was a problem hiding this comment.
This is a lot of work, and I plan to split sub-issues for these.
2643a32 to
f6418d1
Compare
d5d7bf3 to
6f361ee
Compare
jdpleiness
approved these changes
May 20, 2024
6f361ee to
9d18e16
Compare
Very early WIP. Add a go test suite for appliance smoke tests. These tests will be skipped in CI while we figure out what we want smoke tests to do, and in what context they run. We may decide to put them behind an `sg` or possibly `src` subcommand.
9d18e16 to
a5c7b82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early work for https://linear.app/sourcegraph/issue/REL-23/developer-smoke-testing-setup-with-a-real-kubernetes. It doesn't finish the issue. I suspect the output of that issue will actually be to split more sub-issues for the TODOs in here.
Test plan
This PR adds tests, although these are early WIP and are not run in CI yet. This is basically just adding a harness.