This repository was archived by the owner on Sep 30, 2024. It is now read-only.
appliance: split reconciler package into subpackage#62730
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @craigfurman and the rest of your teammates on |
8d5e7a4 to
2643a32
Compare
added 2 commits
May 20, 2024 12:52
Leaving just the frontend in the root of the internal/appliance package. Move some constants into the config subpackage so that they can be shared.
So that it can be easily imported by both reconciler and appliance packages.
2643a32 to
f6418d1
Compare
jdpleiness
approved these changes
May 20, 2024
jdpleiness
left a comment
Contributor
There was a problem hiding this comment.
I took a look at the follow-up PR and this all looks good in context. It makes sense to break these out into packages like you've done here 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this is being able to import config objects from various packages, including the smoke tests that are introduced in the next PR. It might be worth looking at the next PR in the stack in addition to this one.
Test plan
This is a refactor. Existing tests continuing to pass is the validation plan.