Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

sg msp tfc sync: support applying to all services#62565

Merged
bobheadxi merged 1 commit into
mainfrom
msp-tfc-grant-everyone-read_split
May 9, 2024
Merged

sg msp tfc sync: support applying to all services#62565
bobheadxi merged 1 commit into
mainfrom
msp-tfc-grant-everyone-read_split

Conversation

@bobheadxi

@bobheadxi bobheadxi commented May 9, 2024

Copy link
Copy Markdown
Member

For ease of applying Terraform Cloud workspaces changes fleet-wide, e.g. #62559

Test plan

Using -all updates all workspaces:

sg msp tfc sync -all

@cla-bot cla-bot Bot added the cla-signed label May 9, 2024

bobheadxi commented May 9, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

@bobheadxi bobheadxi marked this pull request as ready for review May 9, 2024 01:41
@bobheadxi bobheadxi requested a review from a team May 9, 2024 02:06
Base automatically changed from msp-tfc-grant-everyone-read to main May 9, 2024 16:53
@bobheadxi bobheadxi force-pushed the msp-tfc-grant-everyone-read_split branch from 11cc42f to b4c2ab8 Compare May 9, 2024 16:54

bobheadxi commented May 9, 2024

Copy link
Copy Markdown
Member Author

Merge activity

  • May 9, 12:55 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 9, 1:01 PM EDT: @bobheadxi merged this pull request with Graphite.

@bobheadxi bobheadxi merged commit a4b128f into main May 9, 2024
@bobheadxi bobheadxi deleted the msp-tfc-grant-everyone-read_split branch May 9, 2024 17:01
bobheadxi referenced this pull request May 9, 2024
When using https://github.com/sourcegraph/sourcegraph/pull/62565, we override test environments that are in CLI mode, which can cause infra to be rolled out by surprise via VCS mode on switch - this change adds an option to respect the existing run mode configuration via `-workspace-run-mode=ignore`.

Thread: https://sourcegraph.slack.com/archives/C06JENN2QBF/p1715256898022469?thread_ts=1715251558.736709&cid=C06JENN2QBF

## Test plan

```
sg msp tfc sync -all
👉 Syncing all environments for all services, including setting ALL workspaces to use run mode "vcs" (use '-workspace-run-mode=ignore' to respect the existing run mode) - are you sure? (y/N)  N
❌ aborting
Projects/sourcegraph/managed-services 1 » sg msp tfc sync -all -workspace-run-mode=ignore
👉 Syncing all environments for all services - are you sure? (y/N)  y
// ...
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants