This repository was archived by the owner on Sep 30, 2024. It is now read-only.
msp/terraformcloud: grant 'sso' team read access to MSP workspaces#62559
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @bobheadxi and the rest of your teammates on |
11cc42f to
5f78c27
Compare
michaellzc
approved these changes
May 9, 2024
unknwon
approved these changes
May 9, 2024
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not even being able to view MSP workspaces in the event of e.g. CI failures is quite annoying - this makes MSP workspaces visible to everyone. This is part of addressing feedback from Michael today about the number of Entitle requests required to get a MSP service set up
Also see CORE-37:
Test plan
Using https://github.com/sourcegraph/sourcegraph/pull/62565, I applied this change successfully to all MSP workspaces.