This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg: cloud ephemeral fetch license key from gcp secrets manager#62479
Merged
burmudar merged 5 commits intoMay 8, 2024
Conversation
burmudar
commented
May 7, 2024
13dd854 to
76542ab
Compare
b4b829e to
94d0acb
Compare
filiphaftek
approved these changes
May 7, 2024
| ), nil | ||
| } | ||
|
|
||
| func getCloudEphemeralLicenseKey(ctx context.Context) (string, error) { |
Contributor
There was a problem hiding this comment.
@burmudar the proposal is to make a call to dotcom specific subscription (or msp subscription service?) and create new license for each new instance - this code is fine for today, but for the future re-using license will be blocked.
cc: @michaellzc
burmudar
added a commit
that referenced
this pull request
May 8, 2024
* fix list instances * handle instance not found * use spec values * handle cancel of build when things fail * rebase and refactor * do not cancel build and improve messaging * remove cancelling of build * fixup * sg: cloud ephemeral fetch license key from gcp secrets manager (#62479) * fix list instances * create local dev const and use it with secrets * fetch ephemeral license key from secrets * Update dev/sg/internal/cloud/client.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fetch the license key for cloud ephemeral instances from secrets manager instead of using an env var - which was for dev purposes
Test plan
Tested locally