This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sg: cloud ephemeral check if deployment exists already#62456
Merged
Conversation
e205d2e to
0c63f26
Compare
7c68096 to
f86df58
Compare
burmudar
commented
May 7, 2024
Contributor
Author
There was a problem hiding this comment.
We have to do this since escaping the back ticks doesn't work and it's annoying otherwise
burmudar
commented
May 7, 2024
burmudar
commented
May 7, 2024
Contributor
Author
There was a problem hiding this comment.
Going to keep this - just makes the buildkite client a little more complete
13dd854 to
76542ab
Compare
Strum355
approved these changes
May 8, 2024
* fix list instances * create local dev const and use it with secrets * fetch ephemeral license key from secrets * Update dev/sg/internal/cloud/client.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before trying to create new deployment we check whether the deployment exists already. If it does
Test plan
Tested locally