This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte [RepoPopover]: Instantiate the RepoPopover result across the web-app#61989
Merged
Conversation
0bcf10d to
7a698d3
Compare
7a698d3 to
285af09
Compare
Contributor
camdencheek
reviewed
Apr 23, 2024
fkling
reviewed
Apr 23, 2024
285af09 to
b7107a5
Compare
be8bc3b to
f8a65af
Compare
5c1c919 to
8397f0a
Compare
8397f0a to
089b553
Compare
Member
|
Can we increase the hover delay slightly? It's pretty annoying to have the hovercard show up just when moving the mouse across the screen. screenshot-2024-05-13_15-23-56.mp4 |
camdencheek
reviewed
May 13, 2024
camdencheek
reviewed
May 13, 2024
camdencheek
reviewed
May 13, 2024
camdencheek
reviewed
May 13, 2024
camdencheek
approved these changes
May 13, 2024
…is not in the design spec
089b553 to
f7784f8
Compare
f7784f8 to
3ad6a9d
Compare
camdencheek
added a commit
that referenced
this pull request
May 21, 2024
This re-applies #61989 after it was reverted. In addition to reapplying the change: - It reverts the changes to Popover.svelte that removed the border. - We only start loading data on hover, not on mount - Various fixes in text overflow conditions - Removes the language from the popover data because it can be very expensive to calculate (another reason to pre-calculate language, but that's for another day) - Moves the data loading out of the page loader. Exports the data loading function from the component so data loading is still orchestrated by the caller. (I know this will be controversial, reasoning inline) - Adds a delay to the popover so it doesn't get in the way as your mouse moves over the page. - Uses the display name instead of the author name - Linkifies the commit message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes optimizations and improvements for the RepoPopover, in addition to instantiating the component on the Repo search results page. Not much has changed on the design from the implementation PR. Here is a video to show some live interaction:
Screen.Recording.2024-04-23.at.1.17.27.PM.mov
Test plan
manual, visual test, storybooks, unit tests.