This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Revert "Svelte [RepoPopover]: Instantiate the RepoPopover result across the web-app#62684
Merged
Conversation
camdencheek
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert https://github.com/sourcegraph/sourcegraph/pull/61989
This reverts commit 0d8003f.
It seems that this PR introduced a few problems with Popover styles and it also
adds problematic data fetching on the search result page (we make too many requests as we render different search result blocks); there is also the problem that most of the requests for the repo rev tooltip fail because of auth error.
I revert it for now, but will mark this one as something I check that will go to the June release since Jason did most of the work already, we just need to tune it a bit.
Test plan