This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Admin: avoid false impression that Zoekt is indexing#58793
Merged
Conversation
Contributor
Contributor
Author
|
Here are some screenshots of what it looks like when the index is out of date, and when there's a big delay. It's far from perfect, for example we don't show the actual error, and we don't catch issues with an initial indexing delay. But I think it's definitely an improvement. |
keegancsmith
approved these changes
Dec 7, 2023
Contributor
Author
|
Merging even though |
jtibshirani
added a commit
that referenced
this pull request
Dec 8, 2023
Previously, when an index is not up-to-date, we'd always claim that we're actively indexing the repo. This is misleading, because indexing indexing could be stuck or failing. Now, we remove the loading spinner and just say the repo is "queued for indexing". If the index is out-of-date and it's been more than 8 hours since the last successful job, then we also show a warning tooltip.
keegancsmith
pushed a commit
that referenced
this pull request
Dec 11, 2023
* Admin: add search indexing to repo menu (#58061) When debugging a search issue, it's common to want to check the status of search indexing. Currently, you need to open the repo menu and click through to 'Settings' -> 'Search Indexing', which is not obvious. This change adds 'Search indexing' directly to the repo menu, matching what we do for 'Permissions' and 'Last sync log'. To counterbalance this, this change also removes the 'Embeddings Jobs' item. It felt cluttered to have two 'Embeddings' items, and we want to direct people towards policies instead of manually scheduling jobs. * Admin: improve search indexing icon (#58415) In #58061 we added 'Search indexing' to the repo dropdown menu, in place of having two Embeddings items. However, I forgot to update the icon, so it was using the old Embeddings icon. * Search: clarify wording for indexing job progress (#57903) During a recent support issue, some engineers were confused by the wording, and thought the commit SHA and skipped files related to the in-progress indexing job. In reality, they are describing the last successful job run. This change tries to clarify the wording a bit. * Admin: avoid false impression that Zoekt is indexing (#58793) Previously, when an index is not up-to-date, we'd always claim that we're actively indexing the repo. This is misleading, because indexing indexing could be stuck or failing. Now, we remove the loading spinner and just say the repo is "queued for indexing". If the index is out-of-date and it's been more than 8 hours since the last successful job, then we also show a warning tooltip.
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
Previously, when an index is not up-to-date, we'd always claim that we're actively indexing the repo. This is misleading, because indexing indexing could be stuck or failing. Now, we remove the loading spinner and just say the repo is "queued for indexing". If the index is out-of-date and it's been more than 8 hours since the last successful job, then we also show a warning tooltip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when an index is not up-to-date, we'd always claim that we're
actively indexing the repo. This is misleading, because indexing indexing could
be stuck or failing.
Now, we remove the loading spinner and just say the repo is "queued for
indexing". If the index is out-of-date and it's been more than 8 hours since
the last successful job, then we also show a warning tooltip.
Addresses #57337
Test plan
Lots of manual testing.