Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Admin: improve search indexing icon#58415

Merged
jtibshirani merged 3 commits into
mainfrom
jtibs/search-icon
Nov 20, 2023
Merged

Admin: improve search indexing icon#58415
jtibshirani merged 3 commits into
mainfrom
jtibs/search-icon

Conversation

@jtibshirani

Copy link
Copy Markdown
Contributor

In #58061 we added 'Search indexing' to the repo dropdown menu, in place of
having two Embeddings items. However, I forgot to update the icon, so it was
using the old Embeddings icon.

Test plan

Manual testing

@cla-bot cla-bot Bot added the cla-signed label Nov 17, 2023
@jtibshirani

Copy link
Copy Markdown
Contributor Author

Here's what it looks like now. Very happy to change the icon if there's a better one, I couldn't find any precedent for what to use.
Screenshot 2023-11-17 at 9 51 30 AM

@jtibshirani jtibshirani requested a review from a team November 17, 2023 17:55
@sourcegraph-bot

sourcegraph-bot commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

📖 Storybook live preview

@jtibshirani jtibshirani merged commit 86913ac into main Nov 20, 2023
@jtibshirani jtibshirani deleted the jtibs/search-icon branch November 20, 2023 15:51
jtibshirani added a commit that referenced this pull request Dec 8, 2023
In #58061 we added 'Search indexing' to the repo dropdown menu, in place of
having two Embeddings items. However, I forgot to update the icon, so it was
using the old Embeddings icon.
keegancsmith pushed a commit that referenced this pull request Dec 11, 2023
* Admin: add search indexing to repo menu (#58061)

When debugging a search issue, it's common to want to check the status of
search indexing. Currently, you need to open the repo menu and click through to
'Settings' -> 'Search Indexing', which is not obvious. This change adds 'Search
indexing' directly to the repo menu, matching what we do for 'Permissions' and
'Last sync log'.

To counterbalance this, this change also removes the 'Embeddings Jobs' item. It
felt cluttered to have two 'Embeddings' items, and we want to direct people
towards policies instead of manually scheduling jobs.

* Admin: improve search indexing icon (#58415)

In #58061 we added 'Search indexing' to the repo dropdown menu, in place of
having two Embeddings items. However, I forgot to update the icon, so it was
using the old Embeddings icon.

* Search: clarify wording for indexing job progress (#57903)

During a recent support issue, some engineers were confused by the wording, and thought the commit SHA and skipped files related to the in-progress indexing job. In reality, they are describing the last successful job run. This change tries to clarify the wording a bit.

* Admin: avoid false impression that Zoekt is indexing (#58793)

Previously, when an index is not up-to-date, we'd always claim that we're
actively indexing the repo. This is misleading, because indexing indexing could
be stuck or failing.

Now, we remove the loading spinner and just say the repo is "queued for
indexing". If the index is out-of-date and it's been more than 8 hours since
the last successful job, then we also show a warning tooltip.
vovakulikov pushed a commit that referenced this pull request Dec 12, 2023
In #58061 we added 'Search indexing' to the repo dropdown menu, in place of
having two Embeddings items. However, I forgot to update the icon, so it was
using the old Embeddings icon.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants