This repository was archived by the owner on Sep 30, 2024. It is now read-only.
sec: Make GraphQL cost limits configurable#58346
Merged
Merged
Conversation
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff cb88204...633a35f.
|
75471b8 to
4e3b22f
Compare
eseliger
reviewed
Nov 15, 2023
eaac4d6 to
ba71eeb
Compare
eseliger
approved these changes
Nov 15, 2023
mohammadualam
approved these changes
Nov 15, 2023
7badae0 to
87b0ad3
Compare
Collaborator
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.2 5.2
# Navigate to the new working tree
cd .worktrees/backport-5.2
# Create a new branch
git switch --create backport-58346-to-5.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ac56cacf3ecf6c4ca5f706265edae8d85a7145a
# Push it to GitHub
git push --set-upstream origin backport-58346-to-5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.2If you encouter conflict, first resolve the conflict and stage all files, then run the commands below: git cherry-pick --continue
# Push it to GitHub
git push --set-upstream origin backport-58346-to-5.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.2
|
evict
added a commit
that referenced
this pull request
Nov 15, 2023
* add ratelimit configuration to site-admin (cherry picked from commit 8ac56ca)
evict
added a commit
that referenced
this pull request
Nov 15, 2023
* add ratelimit configuration to site-admin (cherry picked from commit 8ac56ca)
mohammadualam
pushed a commit
that referenced
this pull request
Nov 15, 2023
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
* add ratelimit configuration to site-admin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier for customer site-admin to change the GraphQL limits. It adds a
RateLimitsfunction to fetch the structure and makes sure we have default values.Test plan
CI tests, test locally.